swiotlb: remove an unecessary NULL check
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 5 Apr 2018 11:19:11 +0000 (14:19 +0300)
committerChristoph Hellwig <hch@lst.de>
Mon, 7 May 2018 05:15:41 +0000 (07:15 +0200)
Smatch complains here:

    lib/swiotlb.c:730 swiotlb_alloc_buffer()
    warn: variable dereferenced before check 'dev' (see line 716)

"dev" isn't ever NULL in this function so we can just remove the check.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
lib/swiotlb.c

index 12fbaa4..bd1e0c5 100644 (file)
@@ -727,7 +727,7 @@ swiotlb_alloc_buffer(struct device *dev, size_t size, dma_addr_t *dma_handle,
 
 out_unmap:
        dev_warn(dev, "hwdev DMA mask = 0x%016Lx, dev_addr = 0x%016Lx\n",
-               (unsigned long long)(dev ? dev->coherent_dma_mask : 0),
+               (unsigned long long)dev->coherent_dma_mask,
                (unsigned long long)*dma_handle);
 
        /*