mfd: intel-lpss: Use PCI APIs instead of dereferencing
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 6 Nov 2023 18:40:51 +0000 (20:40 +0200)
committerLee Jones <lee@kernel.org>
Thu, 7 Dec 2023 13:50:25 +0000 (13:50 +0000)
We have a few PCI APIs that may be used instead of direct dereferencing,
Using them will also provide better error codes.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20231106184052.1166579-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/intel-lpss-pci.c

index ae57592..cf56cd3 100644 (file)
@@ -37,13 +37,17 @@ static int intel_lpss_pci_probe(struct pci_dev *pdev,
        if (ret)
                return ret;
 
+       ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
+       if (ret)
+               return ret;
+
        info = devm_kmemdup(&pdev->dev, (void *)id->driver_data, sizeof(*info),
                            GFP_KERNEL);
        if (!info)
                return -ENOMEM;
 
-       info->mem = &pdev->resource[0];
-       info->irq = pdev->irq;
+       info->mem = pci_resource_n(pdev, 0);
+       info->irq = pci_irq_vector(pdev, 0);
 
        if (pci_match_id(ignore_resource_conflicts_ids, pdev))
                info->ignore_resource_conflicts = true;