serial: 8250: Use serial8250_do_set_termios for uartclk updating
authorSerge Semin <fancer.lancer@gmail.com>
Thu, 22 Feb 2024 14:50:56 +0000 (17:50 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 2 Mar 2024 21:04:26 +0000 (22:04 +0100)
The serial8250_update_uartclk() body was created based on the several
method calls copied from the serial8250_do_set_termios() function. Seeing
aside with some other things the later method can update the baud rate
based on the new reference clock let's just call it instead thus
simplifying the code a bit.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/linux-serial/ZczD7KPbeRnY4CFc@black.fi.intel.com
Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20240222145058.28307-1-fancer.lancer@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_port.c

index 4164f86..336a0bd 100644 (file)
@@ -2690,12 +2690,8 @@ static unsigned int serial8250_get_baud_rate(struct uart_port *port,
  */
 void serial8250_update_uartclk(struct uart_port *port, unsigned int uartclk)
 {
-       struct uart_8250_port *up = up_to_u8250p(port);
        struct tty_port *tport = &port->state->port;
-       unsigned int baud, quot, frac = 0;
-       struct ktermios *termios;
        struct tty_struct *tty;
-       unsigned long flags;
 
        tty = tty_port_tty_get(tport);
        if (!tty) {
@@ -2716,21 +2712,7 @@ void serial8250_update_uartclk(struct uart_port *port, unsigned int uartclk)
        if (!tty_port_initialized(tport))
                goto out_unlock;
 
-       termios = &tty->termios;
-
-       baud = serial8250_get_baud_rate(port, termios, NULL);
-       quot = serial8250_get_divisor(port, baud, &frac);
-
-       serial8250_rpm_get(up);
-       uart_port_lock_irqsave(port, &flags);
-
-       uart_update_timeout(port, termios->c_cflag, baud);
-
-       serial8250_set_divisor(port, baud, quot, frac);
-       serial_port_out(port, UART_LCR, up->lcr);
-
-       uart_port_unlock_irqrestore(port, flags);
-       serial8250_rpm_put(up);
+       serial8250_do_set_termios(port, &tty->termios, NULL);
 
 out_unlock:
        mutex_unlock(&tport->mutex);