Bluetooth: btintel: Fix endianness issue for TLV version information
authorKiran K <kiran.k@intel.com>
Thu, 19 Nov 2020 11:39:39 +0000 (17:09 +0530)
committerJohan Hedberg <johan.hedberg@intel.com>
Mon, 7 Dec 2020 15:01:03 +0000 (17:01 +0200)
do __le32_to_cpu to tlv data fields to make sure driver runs
correctly when running on big endian system.

Signed-off-by: Kiran K <kiran.k@intel.com>
Reviewed-by: Chethan T N <chethan.tumkur.narayan@intel.com>
Reviewed-by: Srivatsa Ravishankar <ravishankar.srivatsa@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
drivers/bluetooth/btintel.c

index 88ce5f0..41ff207 100644 (file)
@@ -437,31 +437,38 @@ int btintel_read_version_tlv(struct hci_dev *hdev, struct intel_version_tlv *ver
                tlv = (struct intel_tlv *)skb->data;
                switch (tlv->type) {
                case INTEL_TLV_CNVI_TOP:
-                       version->cnvi_top = get_unaligned_le32(tlv->val);
+                       version->cnvi_top =
+                               __le32_to_cpu(get_unaligned_le32(tlv->val));
                        break;
                case INTEL_TLV_CNVR_TOP:
-                       version->cnvr_top = get_unaligned_le32(tlv->val);
+                       version->cnvr_top =
+                               __le32_to_cpu(get_unaligned_le32(tlv->val));
                        break;
                case INTEL_TLV_CNVI_BT:
-                       version->cnvi_bt = get_unaligned_le32(tlv->val);
+                       version->cnvi_bt =
+                               __le32_to_cpu(get_unaligned_le32(tlv->val));
                        break;
                case INTEL_TLV_CNVR_BT:
-                       version->cnvr_bt = get_unaligned_le32(tlv->val);
+                       version->cnvr_bt =
+                               __le32_to_cpu(get_unaligned_le32(tlv->val));
                        break;
                case INTEL_TLV_DEV_REV_ID:
-                       version->dev_rev_id = get_unaligned_le16(tlv->val);
+                       version->dev_rev_id =
+                               __le16_to_cpu(get_unaligned_le16(tlv->val));
                        break;
                case INTEL_TLV_IMAGE_TYPE:
                        version->img_type = tlv->val[0];
                        break;
                case INTEL_TLV_TIME_STAMP:
-                       version->timestamp = get_unaligned_le16(tlv->val);
+                       version->timestamp =
+                               __le16_to_cpu(get_unaligned_le16(tlv->val));
                        break;
                case INTEL_TLV_BUILD_TYPE:
                        version->build_type = tlv->val[0];
                        break;
                case INTEL_TLV_BUILD_NUM:
-                       version->build_num = get_unaligned_le32(tlv->val);
+                       version->build_num =
+                               __le32_to_cpu(get_unaligned_le32(tlv->val));
                        break;
                case INTEL_TLV_SECURE_BOOT:
                        version->secure_boot = tlv->val[0];