perf cs-etm: Introducing function cs_etm_decoder__init_dparams()

Introducing function cs_etm_decoder__init_dparams() to avoid repeating
code at two different places.

Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Suzuki K Poulouse <suzuki.poulose@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/20190212171618.25355-5-mathieu.poirier@linaro.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h
index 7e6a885..6633094 100644 (file)
--- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h
+++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h
@@ -105,9 +105,10 @@ enum {
        CS_ETM_PROTO_PTM,
 };
 
-enum {
+enum cs_etm_decoder_operation {
        CS_ETM_OPERATION_PRINT = 1,
        CS_ETM_OPERATION_DECODE,
+       CS_ETM_OPERATION_MAX,
 };
 
 int cs_etm_decoder__process_data_block(struct cs_etm_decoder *decoder,

diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
index f396fee..3011c6c 100644 (file)
--- a/tools/perf/util/cs-etm.c
+++ b/tools/perf/util/cs-etm.c
@@ -136,6 +136,28 @@ static void cs_etm__packet_dump(const char *pkt_string)
        fflush(stdout);
 }
 
+static int cs_etm__init_decoder_params(struct cs_etm_decoder_params *d_params,
+                                      struct cs_etm_queue *etmq,
+                                      enum cs_etm_decoder_operation mode)
+{
+       int ret = -EINVAL;
+
+       if (!(mode < CS_ETM_OPERATION_MAX))
+               goto out;
+
+       d_params->packet_printer = cs_etm__packet_dump;
+       d_params->operation = mode;
+       d_params->data = etmq;
+       d_params->formatted = true;
+       d_params->fsyncs = false;
+       d_params->hsyncs = false;
+       d_params->frame_aligned = true;
+
+       ret = 0;
+out:
+       return ret;
+}
+
 static void cs_etm__dump_event(struct cs_etm_auxtrace *etm,
                               struct auxtrace_buffer *buffer)
 {
@@ -182,12 +204,9 @@ static void cs_etm__dump_event(struct cs_etm_auxtrace *etm,
        }
 
        /* Set decoder parameters to simply print the trace packets */
-       d_params.packet_printer = cs_etm__packet_dump;
-       d_params.operation = CS_ETM_OPERATION_PRINT;
-       d_params.formatted = true;
-       d_params.fsyncs = false;
-       d_params.hsyncs = false;
-       d_params.frame_aligned = true;
+       if (cs_etm__init_decoder_params(&d_params, NULL,
+                                       CS_ETM_OPERATION_PRINT))
+               return;
 
        decoder = cs_etm_decoder__new(etm->num_cpu, &d_params, t_params);
 
@@ -436,13 +455,9 @@ static struct cs_etm_queue *cs_etm__alloc_queue(struct cs_etm_auxtrace *etm,
        }
 
        /* Set decoder parameters to simply print the trace packets */
-       d_params.packet_printer = cs_etm__packet_dump;
-       d_params.operation = CS_ETM_OPERATION_DECODE;
-       d_params.formatted = true;
-       d_params.fsyncs = false;
-       d_params.hsyncs = false;
-       d_params.frame_aligned = true;
-       d_params.data = etmq;
+       if (cs_etm__init_decoder_params(&d_params, etmq,
+                                       CS_ETM_OPERATION_DECODE))
+               goto out_free;
 
        etmq->decoder = cs_etm_decoder__new(etm->num_cpu, &d_params, t_params);