scsi: 53c700: Call scsi_done() directly
authorBart Van Assche <bvanassche@acm.org>
Thu, 7 Oct 2021 20:28:06 +0000 (13:28 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:28:44 +0000 (21:28 -0400)
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-12-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/53c700.c

index a12e352..e7ed2fd 100644 (file)
@@ -634,7 +634,7 @@ NCR_700_scsi_done(struct NCR_700_Host_Parameters *hostdata,
 
                SCp->host_scribble = NULL;
                SCp->result = result;
-               SCp->scsi_done(SCp);
+               scsi_done(SCp);
        } else {
                printk(KERN_ERR "53c700: SCSI DONE HAS NULL SCp\n");
        }
@@ -1571,7 +1571,7 @@ NCR_700_intr(int irq, void *dev_id)
                                 * deadlock on the
                                 * hostdata->state_lock */
                                SCp->result = DID_RESET << 16;
-                               SCp->scsi_done(SCp);
+                               scsi_done(SCp);
                        }
                        mdelay(25);
                        NCR_700_chip_setup(host);
@@ -1792,7 +1792,6 @@ NCR_700_queuecommand_lck(struct scsi_cmnd *SCp, void (*done)(struct scsi_cmnd *)
 
        slot->cmnd = SCp;
 
-       SCp->scsi_done = done;
        SCp->host_scribble = (unsigned char *)slot;
        SCp->SCp.ptr = NULL;
        SCp->SCp.buffer = NULL;