mtd: mtd_oobtest: Remove redundant assignment to err

Variable err is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.

Cleans up the following clang-analyzer warning:

drivers/mtd/tests/oobtest.c:626:4: warning: Value stored to 'err' is
never read [clang-analyzer-deadcode.DeadStores].

drivers/mtd/tests/oobtest.c:603:4: warning: Value stored to 'err' is
never read [clang-analyzer-deadcode.DeadStores].

drivers/mtd/tests/oobtest.c:579:4: warning: Value stored to 'err' is
never read [clang-analyzer-deadcode.DeadStores].

drivers/mtd/tests/oobtest.c:556:4: warning: Value stored to 'err' is
never read [clang-analyzer-deadcode.DeadStores].

drivers/mtd/tests/oobtest.c:532:3: warning: Value stored to 'err' is
never read [clang-analyzer-deadcode.DeadStores].

drivers/mtd/tests/oobtest.c:509:3: warning: Value stored to 'err' is
never read [clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/1619346498-43617-1-git-send-email-jiapeng.chong@linux.alibaba.com

diff --git a/drivers/mtd/tests/oobtest.c b/drivers/mtd/tests/oobtest.c
index 590d619..532997e 100644 (file)
--- a/drivers/mtd/tests/oobtest.c
+++ b/drivers/mtd/tests/oobtest.c
@@ -506,7 +506,6 @@ static int __init mtd_oobtest_init(void)
        err = mtd_write_oob(mtd, addr0, &ops);
        if (err) {
                pr_info("error occurred as expected\n");
-               err = 0;
        } else {
                pr_err("error: can write past end of OOB\n");
                errcnt += 1;
@@ -529,7 +528,6 @@ static int __init mtd_oobtest_init(void)
 
        if (err) {
                pr_info("error occurred as expected\n");
-               err = 0;
        } else {
                pr_err("error: can read past end of OOB\n");
                errcnt += 1;
@@ -553,7 +551,6 @@ static int __init mtd_oobtest_init(void)
                err = mtd_write_oob(mtd, mtd->size - mtd->writesize, &ops);
                if (err) {
                        pr_info("error occurred as expected\n");
-                       err = 0;
                } else {
                        pr_err("error: wrote past end of device\n");
                        errcnt += 1;
@@ -576,7 +573,6 @@ static int __init mtd_oobtest_init(void)
 
                if (err) {
                        pr_info("error occurred as expected\n");
-                       err = 0;
                } else {
                        pr_err("error: read past end of device\n");
                        errcnt += 1;
@@ -600,7 +596,6 @@ static int __init mtd_oobtest_init(void)
                err = mtd_write_oob(mtd, mtd->size - mtd->writesize, &ops);
                if (err) {
                        pr_info("error occurred as expected\n");
-                       err = 0;
                } else {
                        pr_err("error: wrote past end of device\n");
                        errcnt += 1;
@@ -623,7 +618,6 @@ static int __init mtd_oobtest_init(void)
 
                if (err) {
                        pr_info("error occurred as expected\n");
-                       err = 0;
                } else {
                        pr_err("error: read past end of device\n");
                        errcnt += 1;