phy: amlogic: meson8b-usb2: Use dev_err_probe()
authorAmjad Ouled-Ameur <aouledameur@baylibre.com>
Tue, 11 Jan 2022 09:52:54 +0000 (10:52 +0100)
committerVinod Koul <vkoul@kernel.org>
Thu, 27 Jan 2022 06:26:54 +0000 (11:56 +0530)
Use the existing dev_err_probe() helper instead of open-coding the same
operation.

Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
Reported-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Link: https://lore.kernel.org/r/20220111095255.176141-3-aouledameur@baylibre.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/amlogic/phy-meson8b-usb2.c

index cf10bed..77e7e9b 100644 (file)
@@ -265,8 +265,9 @@ static int phy_meson8b_usb2_probe(struct platform_device *pdev)
                return PTR_ERR(priv->clk_usb);
 
        priv->reset = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
-       if (PTR_ERR(priv->reset) == -EPROBE_DEFER)
-               return PTR_ERR(priv->reset);
+       if (IS_ERR(priv->reset))
+               return dev_err_probe(&pdev->dev, PTR_ERR(priv->reset),
+                                    "Failed to get the reset line");
 
        priv->dr_mode = of_usb_get_dr_mode_by_phy(pdev->dev.of_node, -1);
        if (priv->dr_mode == USB_DR_MODE_UNKNOWN) {