block: remove the bdgrab in blk_drop_partitions
authorChristoph Hellwig <hch@lst.de>
Thu, 1 Jul 2021 08:16:38 +0000 (10:16 +0200)
committerJens Axboe <axboe@kernel.dk>
Thu, 1 Jul 2021 16:21:24 +0000 (10:21 -0600)
There is no need to hold a bdev reference when removing the partition.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20210701081638.246552-3-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/partitions/core.c

index ed78cdf..4230d4f 100644 (file)
@@ -546,12 +546,8 @@ void blk_drop_partitions(struct gendisk *disk)
 
        lockdep_assert_held(&disk->open_mutex);
 
-       xa_for_each_start(&disk->part_tbl, idx, part, 1) {
-               if (!bdgrab(part))
-                       continue;
+       xa_for_each_start(&disk->part_tbl, idx, part, 1)
                delete_partition(part);
-               bdput(part);
-       }
 }
 
 static bool blk_add_partition(struct gendisk *disk,