remoteproc: qcom_q6v5: Use devm_qcom_smem_state_get() to fix missing put()
authorStephan Gerhold <stephan@gerhold.net>
Fri, 18 Jun 2021 11:15:55 +0000 (13:15 +0200)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Wed, 23 Jun 2021 18:35:18 +0000 (13:35 -0500)
qcom_q6v5 is requesting a smem state with qcom_smem_state_get() but
qcom_smem_state_put() is not called anywhere. Use the new devm_()
variant to fix this without making the code more complicated.

Fixes: 051fb70fd4ea ("remoteproc: qcom: Driver for the self-authenticating Hexagon v5")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Link: https://lore.kernel.org/r/20210618111556.53416-2-stephan@gerhold.net
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/qcom_q6v5.c

index 9627a95..7e9244c 100644 (file)
@@ -280,7 +280,7 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v5, struct platform_device *pdev,
                return ret;
        }
 
-       q6v5->state = qcom_smem_state_get(&pdev->dev, "stop", &q6v5->stop_bit);
+       q6v5->state = devm_qcom_smem_state_get(&pdev->dev, "stop", &q6v5->stop_bit);
        if (IS_ERR(q6v5->state)) {
                dev_err(&pdev->dev, "failed to acquire stop state\n");
                return PTR_ERR(q6v5->state);