USB: gadget: pxa27x_udc: Avoid using GPIOF_ACTIVE_LOW
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 4 Nov 2024 09:34:23 +0000 (11:34 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Sat, 9 Nov 2024 13:55:33 +0000 (14:55 +0100)
Avoid using GPIOF_ACTIVE_LOW as it's deprecated and subject to remove.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20241104093609.156059-6-andriy.shevchenko@linux.intel.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/usb/gadget/udc/pxa27x_udc.c

index 1a6317e..ea79f85 100644 (file)
@@ -2355,18 +2355,19 @@ static int pxa_udc_probe(struct platform_device *pdev)
        struct pxa_udc *udc = &memory;
        int retval = 0, gpio;
        struct pxa2xx_udc_mach_info *mach = dev_get_platdata(&pdev->dev);
-       unsigned long gpio_flags;
 
        if (mach) {
-               gpio_flags = mach->gpio_pullup_inverted ? GPIOF_ACTIVE_LOW : 0;
                gpio = mach->gpio_pullup;
                if (gpio_is_valid(gpio)) {
                        retval = devm_gpio_request_one(&pdev->dev, gpio,
-                                                      gpio_flags,
+                                                      GPIOF_OUT_INIT_LOW,
                                                       "USB D+ pullup");
                        if (retval)
                                return retval;
                        udc->gpiod = gpio_to_desc(mach->gpio_pullup);
+
+                       if (mach->gpio_pullup_inverted ^ gpiod_is_active_low(udc->gpiod))
+                               gpiod_toggle_active_low(udc->gpiod);
                }
                udc->udc_command = mach->udc_command;
        } else {