ASoC: soc-core: add missing return value check for soc_link_init()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tue, 10 Dec 2019 00:34:40 +0000 (09:34 +0900)
committerMark Brown <broonie@kernel.org>
Tue, 10 Dec 2019 13:18:05 +0000 (13:18 +0000)
soc_link_init() returns error code, but snd_soc_bind_card()
is not cheking it.
This patch adds missing return value check for it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/87zhg1xbkv.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-core.c

index 04cb690..2af3df5 100644 (file)
@@ -1983,8 +1983,11 @@ static int snd_soc_bind_card(struct snd_soc_card *card)
                goto probe_end;
        }
 
-       for_each_card_rtds(card, rtd)
-               soc_link_init(card, rtd);
+       for_each_card_rtds(card, rtd) {
+               ret = soc_link_init(card, rtd);
+               if (ret < 0)
+                       goto probe_end;
+       }
 
        snd_soc_dapm_link_dai_widgets(card);
        snd_soc_dapm_connect_dai_link_widgets(card);