drm/xe: Always log GuC/HuC firmware versions
authorLucas De Marchi <lucas.demarchi@intel.com>
Wed, 5 Apr 2023 22:47:25 +0000 (15:47 -0700)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Tue, 19 Dec 2023 23:31:39 +0000 (18:31 -0500)
When debugging issues related to GuC/HuC, it's important to know what is
the firmware version being used. The version from the filename can't be
relied upon, also because it normally only contains the major version
(except for the ones under experimental support).

Log the version from the blob after reading the CSS header. Example:

xe 0000:03:00.0: [drm] Using GuC firmware (70.5) from i915/dg2_guc_70.bin

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Link: https://lore.kernel.org/r/20230405224725.1993719-1-lucas.demarchi@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_uc_fw.c

index 2beee7f..7a410c1 100644 (file)
@@ -395,6 +395,11 @@ int xe_uc_fw_init(struct xe_uc_fw *uc_fw)
        uc_fw->minor_ver_found = FIELD_GET(CSS_SW_VERSION_UC_MINOR,
                                           css->sw_version);
 
+       drm_info(&xe->drm, "Using %s firmware (%u.%u) from %s\n",
+                xe_uc_fw_type_repr(uc_fw->type),
+                uc_fw->major_ver_found, uc_fw->minor_ver_found,
+                uc_fw->path);
+
        err = uc_fw_check_version_requirements(uc_fw);
        if (err)
                goto fail;