greybus: es2.c: Don't use magic value for USB control request
authorAlexandre Bailon <abailon@baylibre.com>
Mon, 15 Jun 2015 16:08:11 +0000 (18:08 +0200)
committerGreg Kroah-Hartman <gregkh@google.com>
Mon, 15 Jun 2015 23:51:44 +0000 (16:51 -0700)
Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/es2.c

index 5257779..a35c79a 100644 (file)
@@ -46,6 +46,12 @@ static DEFINE_KFIFO(apb1_log_fifo, char, APB1_LOG_SIZE);
  */
 #define NUM_CPORT_OUT_URB      8
 
+/* vendor request AP message */
+#define REQUEST_SVC            0x01
+
+/* vendor request APB1 log */
+#define REQUEST_LOG            0x02
+
 /**
  * es1_ap_dev - ES1 USB Bridge to AP structure
  * @usb_dev: pointer to the USB device we are.
@@ -103,7 +109,7 @@ static int submit_svc(struct svc_msg *svc_msg, struct greybus_host_device *hd)
        retval = usb_control_msg(es1->usb_dev,
                                 usb_sndctrlpipe(es1->usb_dev,
                                                 es1->control_endpoint),
-                                0x01,  /* vendor request AP message */
+                                REQUEST_SVC,
                                 USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_INTERFACE,
                                 0x00, 0x00,
                                 (char *)svc_msg,
@@ -410,7 +416,7 @@ static void apb1_log_get(struct es1_ap_dev *es1, char *buf)
                retval = usb_control_msg(es1->usb_dev,
                                        usb_rcvctrlpipe(es1->usb_dev,
                                                        es1->control_endpoint),
-                                       0x02,   /* vendor request APB1 log */
+                                       REQUEST_LOG,
                                        USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_INTERFACE,
                                        0x00, 0x00,
                                        buf,