media: i2c: thp7312: select CONFIG_FW_LOADER
authorArnd Bergmann <arnd@arndb.de>
Wed, 3 Jan 2024 15:58:05 +0000 (16:58 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Thu, 11 Jan 2024 17:43:04 +0000 (18:43 +0100)
The recently added driver uses the firmware loader mechanism but causes
a link failure when that is in a loadable module while thp7312 itself
is built-in:

arm-linux-gnueabi-ld: drivers/media/i2c/thp7312.o: in function `thp7312_probe':
thp7312.c:(.text+0x4164): undefined reference to `firmware_upload_register'

Select the required Kconfig symbol. Note that the driver specifically
needs the firmware upload interface that is controlled by CONFIG_FW_UPLOAD,
but there is no link failure when that is disabled because the interfaces
are stubbed out here.

Link: https://lore.kernel.org/linux-media/20240103155811.4092035-1-arnd@kernel.org
Fixes: 7a52ab415b43 ("media: i2c: Add driver for THine THP7312")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/Kconfig

index 78a8733..4c34359 100644 (file)
@@ -674,6 +674,7 @@ menu "Camera ISPs"
 config VIDEO_THP7312
        tristate "THine THP7312 support"
        depends on I2C
+       select FW_LOADER
        select MEDIA_CONTROLLER
        select V4L2_CCI_I2C
        select V4L2_FWNODE