r8169: use netif_start_queue instead of netif_wake_qeueue in rtl8169_start_xmit
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 21 Mar 2019 20:41:48 +0000 (21:41 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 22 Mar 2019 14:35:25 +0000 (10:35 -0400)
Replace the call to netif_wake_queue in rtl8169_start_xmit with
netif_start_queue as we don't need to actually wake up the queue since
we are still in mid transmit so we just need to reset the bit so it
doesn't prevent the next transmit.
(Description shamelessly copied from a mail sent by Alex.)

Suggested-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169.c

index c29dde0..a4a35e2 100644 (file)
@@ -6264,7 +6264,7 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
                 */
                smp_mb();
                if (rtl_tx_slots_avail(tp, MAX_SKB_FRAGS))
-                       netif_wake_queue(dev);
+                       netif_start_queue(dev);
        }
 
        return NETDEV_TX_OK;