OPP: Properly propagate error along when failing to get icc_path
authorAndrew Halaney <ahalaney@redhat.com>
Mon, 26 Jun 2023 13:46:46 +0000 (08:46 -0500)
committerViresh Kumar <viresh.kumar@linaro.org>
Tue, 27 Jun 2023 02:05:14 +0000 (07:35 +0530)
fa155f4f8348 ("OPP: Use dev_err_probe() when failing to get icc_path")
failed to actually use the error it was trying to log:

    smatch warnings:
    drivers/opp/of.c:516 dev_pm_opp_of_find_icc_paths() warn: passing zero to 'dev_err_probe'

Make sure to use the right error and pass it along.

Fixes: fa155f4f8348 ("OPP: Use dev_err_probe() when failing to get icc_path")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202306262008.guNLgjt6-lkp@intel.com/
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/opp/of.c

index 1f0923c..ada4963 100644 (file)
@@ -513,7 +513,7 @@ int dev_pm_opp_of_find_icc_paths(struct device *dev,
        for (i = 0; i < num_paths; i++) {
                paths[i] = of_icc_get_by_index(dev, i);
                if (IS_ERR(paths[i])) {
-                       ret = dev_err_probe(dev, ret, "%s: Unable to get path%d\n", __func__, i);
+                       ret = dev_err_probe(dev, PTR_ERR(paths[i]), "%s: Unable to get path%d\n", __func__, i);
                        goto err;
                }
        }