rtc: rx8025: switch to devm_rtc_allocate_device
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 7 Nov 2021 22:54:52 +0000 (23:54 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 9 Nov 2021 23:45:57 +0000 (00:45 +0100)
Switch to devm_rtc_allocate_device/devm_rtc_register_device, this allows
for further improvement of the driver.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20211107225458.111068-7-alexandre.belloni@bootlin.com
drivers/rtc/rtc-rx8025.c

index d38aaf0..617b044 100644 (file)
@@ -559,12 +559,11 @@ static int rx8025_probe(struct i2c_client *client,
        if (err)
                return err;
 
-       rx8025->rtc = devm_rtc_device_register(&client->dev, client->name,
-                                         &rx8025_rtc_ops, THIS_MODULE);
-       if (IS_ERR(rx8025->rtc)) {
-               dev_err(&client->dev, "unable to register the class device\n");
+       rx8025->rtc = devm_rtc_allocate_device(&client->dev);
+       if (IS_ERR(rx8025->rtc))
                return PTR_ERR(rx8025->rtc);
-       }
+
+       rx8025->rtc->ops = &rx8025_rtc_ops;
 
        if (client->irq > 0) {
                dev_info(&client->dev, "IRQ %d supplied\n", client->irq);
@@ -583,6 +582,10 @@ static int rx8025_probe(struct i2c_client *client,
        /* the rx8025 alarm only supports a minute accuracy */
        rx8025->rtc->uie_unsupported = 1;
 
+       err = devm_rtc_register_device(rx8025->rtc);
+       if (err)
+               return err;
+
        err = rx8025_sysfs_register(&client->dev);
        return err;
 }