projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e913aad
)
usb: cdnsp: Fix the IMAN_IE_SET and IMAN_IE_CLEAR macro
author
Christophe JAILLET
<christophe.jaillet@wanadoo.fr>
Tue, 22 Jun 2021 19:37:48 +0000
(21:37 +0200)
committer
Peter Chen
<peter.chen@zeku.com>
Thu, 29 Jul 2021 06:28:15 +0000
(14:28 +0800)
IMAN_IE is BIT(1), so these macro are respectively equivalent to BIT(1)
and 0, whatever the value of 'p'.
The purpose was to set and reset a single bit in 'p'.
Fix these macros to do that correctly.
Acked-by: Pawel Laszczak <pawell@cadence.com>
Fixes:
e93e58d27402
("usb: cdnsp: Device side header file for CDNSP driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link:
https://lore.kernel.org/r/d12bfcc9cbffb89e27b120668821b3c4f09b6755.1624390584.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Peter Chen <peter.chen@kernel.org>
drivers/usb/cdns3/cdnsp-gadget.h
patch
|
blob
|
history
diff --git
a/drivers/usb/cdns3/cdnsp-gadget.h
b/drivers/usb/cdns3/cdnsp-gadget.h
index
783ca8f
..
f740fa6
100644
(file)
--- a/
drivers/usb/cdns3/cdnsp-gadget.h
+++ b/
drivers/usb/cdns3/cdnsp-gadget.h
@@
-383,8
+383,8
@@
struct cdnsp_intr_reg {
#define IMAN_IE BIT(1)
#define IMAN_IP BIT(0)
/* bits 2:31 need to be preserved */
-#define IMAN_IE_SET(p) ((
(p) & IMAN_IE) | 0x2
)
-#define IMAN_IE_CLEAR(p) ((
(p) & IMAN_IE) & ~(0x2)
)
+#define IMAN_IE_SET(p) ((
p) | IMAN_IE
)
+#define IMAN_IE_CLEAR(p) ((
p) & ~IMAN_IE
)
/* IMOD - Interrupter Moderation Register - irq_control bitmasks. */
/*