bcache: add code comments in bch_btree_leaf_dirty()
authorColy Li <colyli@suse.de>
Wed, 13 Nov 2019 08:03:22 +0000 (16:03 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 13 Nov 2019 22:42:50 +0000 (15:42 -0700)
This patch adds code comments in bch_btree_leaf_dirty() to explain
why w->journal should always reference the eldest journal pin of
all the writing bkeys in the btree node. To make the bcache journal
code to be easier to be understood.

Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/bcache/btree.c

index 39d7fc1..48e33ee 100644 (file)
@@ -569,6 +569,11 @@ static void bch_btree_leaf_dirty(struct btree *b, atomic_t *journal_ref)
 
        set_btree_node_dirty(b);
 
+       /*
+        * w->journal is always the oldest journal pin of all bkeys
+        * in the leaf node, to make sure the oldest jset seq won't
+        * be increased before this btree node is flushed.
+        */
        if (journal_ref) {
                if (w->journal &&
                    journal_pin_cmp(b->c, w->journal, journal_ref)) {