projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
67fb0cc
)
usb: typec: anx7411: Fix return value check in anx7411_register_i2c_dummy_clients()
author
Yang Yingliang
<yangyingliang@huawei.com>
Thu, 21 Jul 2022 07:12:00 +0000
(15:12 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 27 Jul 2022 12:27:53 +0000
(14:27 +0200)
If i2c_new_dummy_device() fails, it never return NULL pointer, replace
NULL test with IS_ERR() to fix it.
Fixes:
fe6d8a9c8e64
("usb: typec: anx7411: Add Analogix PD ANX7411 support")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link:
https://lore.kernel.org/r/20220721071201.269344-2-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/anx7411.c
patch
|
blob
|
history
diff --git
a/drivers/usb/typec/anx7411.c
b/drivers/usb/typec/anx7411.c
index
e16c2d5
..
7692e26
100644
(file)
--- a/
drivers/usb/typec/anx7411.c
+++ b/
drivers/usb/typec/anx7411.c
@@
-999,7
+999,7
@@
static int anx7411_register_i2c_dummy_clients(struct anx7411_data *ctx,
spi_addr = anx7411_i2c_addr[i].spi_address >> 1;
ctx->spi_client = i2c_new_dummy_device(client->adapter,
spi_addr);
- if (
ctx->spi_client
)
+ if (
!IS_ERR(ctx->spi_client)
)
return 0;
}
}