misc: bcm_vk: Remove usage of deprecated functions
authorBreno Leitao <leitao@debian.org>
Fri, 12 Aug 2022 09:47:17 +0000 (02:47 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 1 Sep 2022 14:29:32 +0000 (16:29 +0200)
ida_simple_get() and ida_simple_remove() functions are deprecated now.
These functions were replaced by ida_alloc() and ida_free()
respectively. This patch modernize bcm_vk to use the replacement
functions.

Acked-by: Scott Branden <scott.branden@broadcom.com>
Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://lore.kernel.org/r/20220812094717.4097179-1-leitao@debian.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/bcm-vk/bcm_vk_dev.c

index bedab17..d4a9613 100644 (file)
@@ -1401,7 +1401,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                bcm_vk_tty_set_irq_enabled(vk, i);
        }
 
-       id = ida_simple_get(&bcm_vk_ida, 0, 0, GFP_KERNEL);
+       id = ida_alloc(&bcm_vk_ida, GFP_KERNEL);
        if (id < 0) {
                err = id;
                dev_err(dev, "unable to get id\n");
@@ -1500,7 +1500,7 @@ err_kfree_name:
        misc_device->name = NULL;
 
 err_ida_remove:
-       ida_simple_remove(&bcm_vk_ida, id);
+       ida_free(&bcm_vk_ida, id);
 
 err_irq:
        for (i = 0; i < vk->num_irqs; i++)
@@ -1573,7 +1573,7 @@ static void bcm_vk_remove(struct pci_dev *pdev)
        if (misc_device->name) {
                misc_deregister(misc_device);
                kfree(misc_device->name);
-               ida_simple_remove(&bcm_vk_ida, vk->devid);
+               ida_free(&bcm_vk_ida, vk->devid);
        }
        for (i = 0; i < vk->num_irqs; i++)
                devm_free_irq(&pdev->dev, pci_irq_vector(pdev, i), vk);