Input: cs40l50 - fix wrong usage of INIT_WORK()

In cs40l50_add(), the work_data is a local variable and the work_data.work
should initialize with INIT_WORK_ONSTACK() instead of INIT_WORK().
Small error in cs40l50_erase() also fixed in this commit.

Fixes: c38fe1bb5d21 ("Input: cs40l50 - Add support for the CS40L50 haptic driver")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Reviewed-by: James Ogletree <jogletre@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20241106013549.78142-1-yuancan@huawei.com
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

diff --git a/drivers/input/misc/cs40l50-vibra.c b/drivers/input/misc/cs40l50-vibra.c
index 03bdb7c..dce3b0e 100644 (file)
--- a/drivers/input/misc/cs40l50-vibra.c
+++ b/drivers/input/misc/cs40l50-vibra.c
@@ -334,11 +334,12 @@ static int cs40l50_add(struct input_dev *dev, struct ff_effect *effect,
        work_data.custom_len = effect->u.periodic.custom_len;
        work_data.vib = vib;
        work_data.effect = effect;
-       INIT_WORK(&work_data.work, cs40l50_add_worker);
+       INIT_WORK_ONSTACK(&work_data.work, cs40l50_add_worker);
 
        /* Push to the workqueue to serialize with playbacks */
        queue_work(vib->vib_wq, &work_data.work);
        flush_work(&work_data.work);
+       destroy_work_on_stack(&work_data.work);
 
        kfree(work_data.custom_data);
 
@@ -467,11 +468,12 @@ static int cs40l50_erase(struct input_dev *dev, int effect_id)
        work_data.vib = vib;
        work_data.effect = &dev->ff->effects[effect_id];
 
-       INIT_WORK(&work_data.work, cs40l50_erase_worker);
+       INIT_WORK_ONSTACK(&work_data.work, cs40l50_erase_worker);
 
        /* Push to workqueue to serialize with playbacks */
        queue_work(vib->vib_wq, &work_data.work);
        flush_work(&work_data.work);
+       destroy_work_on_stack(&work_data.work);
 
        return work_data.error;
 }