drm/i915: Fix FB WM for HSW
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 9 Aug 2013 15:02:09 +0000 (18:02 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 9 Aug 2013 18:27:43 +0000 (20:27 +0200)
Due to a misplaced memset(), we never actually enabled the FBC WM on HSW.
Move the memset() to happen a bit earlier, so that it won't clobber
results->enable_fbc_wm.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_pm.c

index 6643069..3ac5fe9 100644 (file)
@@ -2681,6 +2681,8 @@ static void hsw_compute_wm_results(struct drm_device *dev,
                        break;
        max_level = level - 1;
 
+       memset(results, 0, sizeof(*results));
+
        /* The spec says it is preferred to disable FBC WMs instead of disabling
         * a WM level. */
        results->enable_fbc_wm = true;
@@ -2691,7 +2693,6 @@ static void hsw_compute_wm_results(struct drm_device *dev,
                }
        }
 
-       memset(results, 0, sizeof(*results));
        for (wm_lp = 1; wm_lp <= 3; wm_lp++) {
                const struct intel_wm_level *r;