mtd: mtdpart: check for subpartitions parsing result
authorRafał Miłecki <rafal@milecki.pl>
Wed, 27 Sep 2023 20:26:57 +0000 (22:26 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Mon, 16 Oct 2023 08:50:32 +0000 (10:50 +0200)
parse_mtd_partitions() may return an error so it should be checked and
optionally passed up

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20230927202657.27169-1-zajec5@gmail.com
drivers/mtd/mtdpart.c

index 23483db..6811a71 100644 (file)
@@ -426,7 +426,11 @@ int add_mtd_partitions(struct mtd_info *parent,
                mtd_add_partition_attrs(child);
 
                /* Look for subpartitions */
-               parse_mtd_partitions(child, parts[i].types, NULL);
+               ret = parse_mtd_partitions(child, parts[i].types, NULL);
+               if (ret < 0) {
+                       pr_err("Failed to parse subpartitions: %d\n", ret);
+                       goto err_del_partitions;
+               }
 
                cur_offset = child->part.offset + child->part.size;
        }