net: ethernet: ti: am65-cpsw: Use __be64 type for id_temp
authorSimon Horman <horms@kernel.org>
Thu, 10 Oct 2024 11:04:10 +0000 (12:04 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Oct 2024 12:20:41 +0000 (13:20 +0100)
The id_temp local variable in am65_cpsw_nuss_probe() is
used to hold a 64-bit big-endian value as it is assigned using
cpu_to_be64().

It is read using memcpy(), where it is written as an identifier into a
byte-array.  So this can also be treated as big endian.

As it's type is currently host byte order (u64), sparse flags
an endian mismatch when compiling for little-endian systems:

.../am65-cpsw-nuss.c:3454:17: warning: incorrect type in assignment (different base types)
.../am65-cpsw-nuss.c:3454:17:    expected unsigned long long [usertype] id_temp
.../am65-cpsw-nuss.c:3454:17:    got restricted __be64 [usertype]

Address this by using __be64 as the type of id_temp.

No functional change intended.
Compile tested only.

Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Signed-off-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/am65-cpsw-nuss.c

index aee98ff..bb3e636 100644 (file)
@@ -3500,7 +3500,7 @@ static int am65_cpsw_nuss_probe(struct platform_device *pdev)
        struct resource *res;
        struct clk *clk;
        int ale_entries;
-       u64 id_temp;
+       __be64 id_temp;
        int ret, i;
 
        common = devm_kzalloc(dev, sizeof(struct am65_cpsw_common), GFP_KERNEL);