ASoC: ux500: mop500: rename shadowing variable
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 26 Mar 2021 21:59:26 +0000 (16:59 -0500)
committerMark Brown <broonie@kernel.org>
Wed, 31 Mar 2021 17:03:27 +0000 (18:03 +0100)
cppcheck warning:

sound/soc/ux500/mop500.c:143:23: style: Local variable 'mop500_card'
shadows outer variable [shadowVariable]

 struct snd_soc_card *mop500_card = platform_get_drvdata(pdev);
                      ^
sound/soc/ux500/mop500.c:54:28: note: Shadowed declaration
static struct snd_soc_card mop500_card = {
                           ^
sound/soc/ux500/mop500.c:143:23: note: Shadow variable
 struct snd_soc_card *mop500_card = platform_get_drvdata(pdev);
                      ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210326215927.936377-17-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/ux500/mop500.c

index cdae119..4f41bb0 100644 (file)
@@ -140,12 +140,12 @@ static int mop500_probe(struct platform_device *pdev)
 
 static int mop500_remove(struct platform_device *pdev)
 {
-       struct snd_soc_card *mop500_card = platform_get_drvdata(pdev);
+       struct snd_soc_card *card = platform_get_drvdata(pdev);
 
        pr_debug("%s: Enter.\n", __func__);
 
-       snd_soc_unregister_card(mop500_card);
-       mop500_ab8500_remove(mop500_card);
+       snd_soc_unregister_card(card);
+       mop500_ab8500_remove(card);
        mop500_of_node_put();
 
        return 0;