selftests: netfilter: fix nft_meta.sh error reporting
authorFabian Frederick <fabf@skynet.be>
Wed, 9 Sep 2020 18:26:13 +0000 (20:26 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 21 Sep 2020 23:55:11 +0000 (01:55 +0200)
When some test directly done with check_one_counter() fails,
counter variable is undefined. This patch calls ip with cname
which avoids errors like:
FAIL: oskuidcounter, want "packets 2", got
Error: syntax error, unexpected newline, expecting string
list counter inet filter
                        ^
Error is now correctly rendered:
FAIL: oskuidcounter, want "packets 2", got
table inet filter {
counter oskuidcounter {
packets 1 bytes 84
}
}

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
tools/testing/selftests/netfilter/nft_meta.sh

index 17b2d6e..1f5b465 100755 (executable)
@@ -90,7 +90,7 @@ check_one_counter()
        if [ $? -ne 0 ];then
                echo "FAIL: $cname, want \"$want\", got"
                ret=1
-               ip netns exec "$ns0" nft list counter inet filter $counter
+               ip netns exec "$ns0" nft list counter inet filter $cname
        fi
 }