block: blkdev_issue_secure_erase loop style
authorKeith Busch <kbusch@kernel.org>
Fri, 23 Feb 2024 15:59:07 +0000 (07:59 -0800)
committerJens Axboe <axboe@kernel.dk>
Sat, 24 Feb 2024 19:46:46 +0000 (12:46 -0700)
Use consistent coding style in this file. All the other loops for the
same purpose use "while (nr_sects)", so they win.

Reviewed-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20240223155910.3622666-2-kbusch@meta.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-lib.c

index e59c306..91770da 100644 (file)
@@ -322,7 +322,7 @@ int blkdev_issue_secure_erase(struct block_device *bdev, sector_t sector,
                return -EPERM;
 
        blk_start_plug(&plug);
-       for (;;) {
+       while (nr_sects) {
                unsigned int len = min_t(sector_t, nr_sects, max_sectors);
 
                bio = blk_next_bio(bio, bdev, 0, REQ_OP_SECURE_ERASE, gfp);
@@ -331,13 +331,12 @@ int blkdev_issue_secure_erase(struct block_device *bdev, sector_t sector,
 
                sector += len;
                nr_sects -= len;
-               if (!nr_sects) {
-                       ret = submit_bio_wait(bio);
-                       bio_put(bio);
-                       break;
-               }
                cond_resched();
        }
+       if (bio) {
+               ret = submit_bio_wait(bio);
+               bio_put(bio);
+       }
        blk_finish_plug(&plug);
 
        return ret;