mptcp: implement mptcp_pm_connection_closed

The MPTCP path manager event handler mptcp_pm_connection_closed
interface has been added in the commit 1b1c7a0ef7f3 ("mptcp: Add path
manager interface") but it was an empty function from then on.

With such name, it sounds good to invoke mptcp_event with the
MPTCP_EVENT_CLOSED event type from it. It also removes a bit of
duplicated code.

Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20241021-net-next-mptcp-misc-6-13-v1-3-1ef02746504a@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/net/mptcp/pm.c b/net/mptcp/pm.c
index 620264c..16c336c 100644 (file)
--- a/net/mptcp/pm.c
+++ b/net/mptcp/pm.c
@@ -154,6 +154,9 @@ void mptcp_pm_fully_established(struct mptcp_sock *msk, const struct sock *ssk)
 void mptcp_pm_connection_closed(struct mptcp_sock *msk)
 {
        pr_debug("msk=%p\n", msk);
+
+       if (msk->token)
+               mptcp_event(MPTCP_EVENT_CLOSED, msk, NULL, GFP_KERNEL);
 }
 
 void mptcp_pm_subflow_established(struct mptcp_sock *msk)

diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index a6c9661..e978e05 100644 (file)
--- a/net/mptcp/protocol.c
+++ b/net/mptcp/protocol.c
@@ -3139,8 +3139,7 @@ cleanup:
 
        sock_hold(sk);
        pr_debug("msk=%p state=%d\n", sk, sk->sk_state);
-       if (msk->token)
-               mptcp_event(MPTCP_EVENT_CLOSED, msk, NULL, GFP_KERNEL);
+       mptcp_pm_connection_closed(msk);
 
        if (sk->sk_state == TCP_CLOSE) {
                __mptcp_destroy_sock(sk);
@@ -3206,8 +3205,7 @@ static int mptcp_disconnect(struct sock *sk, int flags)
        mptcp_stop_rtx_timer(sk);
        mptcp_stop_tout_timer(sk);
 
-       if (msk->token)
-               mptcp_event(MPTCP_EVENT_CLOSED, msk, NULL, GFP_KERNEL);
+       mptcp_pm_connection_closed(msk);
 
        /* msk->subflow is still intact, the following will not free the first
         * subflow