power: avs: fix uninitialized error return on failed cpr_read_fuse_uV() call
authorColin Ian King <colin.king@canonical.com>
Mon, 6 Jan 2020 12:05:58 +0000 (12:05 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 7 Jan 2020 10:57:45 +0000 (11:57 +0100)
Currently when the call cpr_read_fuse_uV returns an error the value in the
uninitialized variable ret is returned. Fix this by instread returning the
error value in the variable uV.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: bf6910abf548 ("power: avs: Add support for CPR (Core Power Reduction)")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/power/avs/qcom-cpr.c

index 9247f53..0321729 100644 (file)
@@ -922,7 +922,7 @@ static int cpr_fuse_corner_init(struct cpr_drv *drv)
                uV = cpr_read_fuse_uV(desc, fdata, fuses->init_voltage,
                                      step_volt, drv);
                if (uV < 0)
-                       return ret;
+                       return uV;
 
                fuse->min_uV = fdata->min_uV;
                fuse->max_uV = fdata->max_uV;