ASoC: samsung: i2s: remove unassigned variable
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 19 Feb 2021 23:09:13 +0000 (17:09 -0600)
committerMark Brown <broonie@kernel.org>
Wed, 10 Mar 2021 13:06:49 +0000 (13:06 +0000)
cppcheck warning:

sound/soc/samsung/i2s.c:1159:18: style: Variable 'dai' is not assigned
a value. [unassignedVariable]
 struct i2s_dai *dai;
                 ^

This variable is only used for a sizeof(*dai).

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20210219230918.5058-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/samsung/i2s.c

index b043183..c632842 100644 (file)
@@ -1156,11 +1156,10 @@ static int i2s_alloc_dais(struct samsung_i2s_priv *priv,
        static const char *stream_names[] = { "Primary Playback",
                                              "Secondary Playback" };
        struct snd_soc_dai_driver *dai_drv;
-       struct i2s_dai *dai;
        int i;
 
        priv->dai = devm_kcalloc(&priv->pdev->dev, num_dais,
-                                    sizeof(*dai), GFP_KERNEL);
+                                    sizeof(struct i2s_dai), GFP_KERNEL);
        if (!priv->dai)
                return -ENOMEM;