phy: rockchip-inno-usb2: Do not lock in bvalid IRQ handler
authorSamuel Holland <samuel@sholland.org>
Thu, 14 Apr 2022 03:22:54 +0000 (22:22 -0500)
committerVinod Koul <vkoul@kernel.org>
Wed, 20 Apr 2022 09:14:03 +0000 (14:44 +0530)
Clearing the IRQ is atomic, so there is no need to hold the mutex.

Signed-off-by: Samuel Holland <samuel@sholland.org>
Tested-by: Michael Riesch <michael.riesch@wolfvision.net>
Link: https://lore.kernel.org/r/20220414032258.40984-4-samuel@sholland.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/rockchip/phy-rockchip-inno-usb2.c

index 29407b3..3422db5 100644 (file)
@@ -905,13 +905,9 @@ static irqreturn_t rockchip_usb2phy_bvalid_irq(int irq, void *data)
        if (!property_enabled(rphy->grf, &rport->port_cfg->bvalid_det_st))
                return IRQ_NONE;
 
-       mutex_lock(&rport->mutex);
-
        /* clear bvalid detect irq pending status */
        property_enable(rphy->grf, &rport->port_cfg->bvalid_det_clr, true);
 
-       mutex_unlock(&rport->mutex);
-
        rockchip_usb2phy_otg_sm_work(&rport->otg_sm_work.work);
 
        return IRQ_HANDLED;