KVM: x86/mmu: Remove unnecessary warnings from restore_acc_track_spte()
authorDavid Matlack <dmatlack@google.com>
Wed, 19 Jan 2022 23:07:29 +0000 (23:07 +0000)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 10 Feb 2022 18:50:39 +0000 (13:50 -0500)
The warnings in restore_acc_track_spte() can be removed because the only
caller checks is_access_track_spte(), and is_access_track_spte() checks
!spte_ad_enabled(). In other words, the warning can never be triggered.

No functional change intended.

Suggested-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: David Matlack <dmatlack@google.com>
Message-Id: <20220119230739.2234394-9-dmatlack@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/mmu/mmu.c

index 443c1b3..51b9cb9 100644 (file)
@@ -652,9 +652,6 @@ static u64 restore_acc_track_spte(u64 spte)
        u64 saved_bits = (spte >> SHADOW_ACC_TRACK_SAVED_BITS_SHIFT)
                         & SHADOW_ACC_TRACK_SAVED_BITS_MASK;
 
-       WARN_ON_ONCE(spte_ad_enabled(spte));
-       WARN_ON_ONCE(!is_access_track_spte(spte));
-
        new_spte &= ~shadow_acc_track_mask;
        new_spte &= ~(SHADOW_ACC_TRACK_SAVED_BITS_MASK <<
                      SHADOW_ACC_TRACK_SAVED_BITS_SHIFT);