net/netrom: prefer strscpy over strcpy

The deprecated helper strcpy() performs no bounds checking on the
destination buffer. This could result in linear overflows beyond
the end of the buffer, leading to all kinds of misbehaviors.
The safe replacement is strscpy() [1].

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy
Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
Link: https://patch.msgid.link/20240828123224.3697672-4-lihongbo22@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index bd2b17b..2b5e246 100644 (file)
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -189,7 +189,7 @@ static int __must_check nr_add_node(ax25_address *nr, const char *mnemonic,
                }
 
                nr_node->callsign = *nr;
-               strcpy(nr_node->mnemonic, mnemonic);
+               strscpy(nr_node->mnemonic, mnemonic);
 
                nr_node->which = 0;
                nr_node->count = 1;
@@ -214,7 +214,7 @@ static int __must_check nr_add_node(ax25_address *nr, const char *mnemonic,
        nr_node_lock(nr_node);
 
        if (quality != 0)
-               strcpy(nr_node->mnemonic, mnemonic);
+               strscpy(nr_node->mnemonic, mnemonic);
 
        for (found = 0, i = 0; i < nr_node->count; i++) {
                if (nr_node->routes[i].neighbour == nr_neigh) {