rtc: coh901331: fix a missing check of clk_prepare
authorKangjie Lu <kjlu@umn.edu>
Wed, 26 Dec 2018 02:43:33 +0000 (20:43 -0600)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 22 Jan 2019 18:01:19 +0000 (19:01 +0100)
clk_prepare() could fail, so let's check its status and if it fails
return its error code upstream.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-coh901331.c

index fc5cf5c..0b232c8 100644 (file)
@@ -235,9 +235,13 @@ static int coh901331_suspend(struct device *dev)
 
 static int coh901331_resume(struct device *dev)
 {
+       int ret;
        struct coh901331_port *rtap = dev_get_drvdata(dev);
 
-       clk_prepare(rtap->clk);
+       ret = clk_prepare(rtap->clk);
+       if (ret)
+               return ret;
+
        if (device_may_wakeup(dev)) {
                disable_irq_wake(rtap->irq);
        } else {