gpu: drm: amdgpu: Replace mdelay with msleep in cik_pcie_gen3_enable()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Mon, 23 Jul 2018 14:29:56 +0000 (22:29 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 25 Jul 2018 20:06:40 +0000 (15:06 -0500)
cik_pcie_gen3_enable() is only called by cik_common_hw_init(), which is
never called in atomic context.
cik_pcie_gen3_enable() calls mdelay() to busily wait, which is not
necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/cik.c

index 702e257..78ab939 100644 (file)
@@ -1476,7 +1476,7 @@ static void cik_pcie_gen3_enable(struct amdgpu_device *adev)
                                tmp |= PCIE_LC_CNTL4__LC_REDO_EQ_MASK;
                                WREG32_PCIE(ixPCIE_LC_CNTL4, tmp);
 
-                               mdelay(100);
+                               msleep(100);
 
                                /* linkctl */
                                pci_read_config_word(root, bridge_pos + PCI_EXP_LNKCTL, &tmp16);