remoteproc: k3-dsp: Use devm_kzalloc() helper

Use device lifecycle managed devm_kzalloc() helper function. This helps
prevent mistakes like freeing out of order in cleanup functions and
forgetting to free on all error paths.

Signed-off-by: Andrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20240205182753.36978-3-afd@ti.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
index 64ec575..b9332c6 100644 (file)
--- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c
+++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
@@ -659,7 +659,7 @@ struct ti_sci_proc *k3_dsp_rproc_of_get_tsp(struct device *dev,
        if (ret < 0)
                return ERR_PTR(ret);
 
-       tsp = kzalloc(sizeof(*tsp), GFP_KERNEL);
+       tsp = devm_kzalloc(dev, sizeof(*tsp), GFP_KERNEL);
        if (!tsp)
                return ERR_PTR(-ENOMEM);
 
@@ -730,7 +730,7 @@ static int k3_dsp_rproc_probe(struct platform_device *pdev)
        ret = ti_sci_proc_request(kproc->tsp);
        if (ret < 0) {
                dev_err_probe(dev, ret, "ti_sci_proc_request failed\n");
-               goto free_tsp;
+               return ret;
        }
 
        ret = k3_dsp_rproc_of_get_memories(pdev, kproc);
@@ -797,8 +797,6 @@ release_tsp:
        ret1 = ti_sci_proc_release(kproc->tsp);
        if (ret1)
                dev_err(dev, "failed to release proc (%pe)\n", ERR_PTR(ret1));
-free_tsp:
-       kfree(kproc->tsp);
        return ret;
 }
 
@@ -824,8 +822,6 @@ static void k3_dsp_rproc_remove(struct platform_device *pdev)
        if (ret)
                dev_err(dev, "failed to release proc (%pe)\n", ERR_PTR(ret));
 
-       kfree(kproc->tsp);
-
        k3_dsp_reserved_mem_exit(kproc);
 }