cxl/mem: Return -EFAULT if copy_to_user() fails
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 19 Feb 2021 09:54:38 +0000 (12:54 +0300)
committerDan Williams <dan.j.williams@intel.com>
Fri, 19 Feb 2021 15:40:23 +0000 (07:40 -0800)
The copy_to_user() function returns the number of bytes remaining to be
copied, but we want to return -EFAULT if the copy doesn't complete.

Fixes: b754ffbbc0ee ("cxl/mem: Add basic IOCTL interface")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YC+K3kgzqm20zCWY@mwanda
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/cxl/mem.c

index 6d7d387..df895bc 100644 (file)
@@ -752,7 +752,10 @@ static int cxl_send_cmd(struct cxl_memdev *cxlmd,
        if (rc)
                return rc;
 
-       return copy_to_user(s, &send, sizeof(send));
+       if (copy_to_user(s, &send, sizeof(send)))
+               return -EFAULT;
+
+       return 0;
 }
 
 static long __cxl_memdev_ioctl(struct cxl_memdev *cxlmd, unsigned int cmd,