scsi: ufs: core: Remove redundant host_lock calls around UTMRLCLR
authorAvri Altman <avri.altman@wdc.com>
Thu, 24 Oct 2024 07:50:32 +0000 (10:50 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Oct 2024 19:03:15 +0000 (15:03 -0400)
There is no need to serialize single read/write calls to the host
controller registers. Remove the redundant host_lock calls that protect
access to the task management request List cLear register: UTMRLCLR.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Avri Altman <avri.altman@wdc.com>
Link: https://lore.kernel.org/r/20241024075033.562562-3-avri.altman@wdc.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufshcd.c

index 5827575..f6e84a3 100644 (file)
@@ -6995,14 +6995,11 @@ static int ufshcd_clear_tm_cmd(struct ufs_hba *hba, int tag)
 {
        int err = 0;
        u32 mask = 1 << tag;
-       unsigned long flags;
 
        if (!test_bit(tag, &hba->outstanding_tasks))
                goto out;
 
-       spin_lock_irqsave(hba->host->host_lock, flags);
        ufshcd_utmrl_clear(hba, tag);
-       spin_unlock_irqrestore(hba->host->host_lock, flags);
 
        /* poll for max. 1 sec to clear door bell register by h/w */
        err = ufshcd_wait_for_register(hba,