drm/bridge: anx7625: Convert to use devm_kzalloc
authorHsin-Yi Wang <hsinyi@chromium.org>
Sun, 13 Feb 2022 10:34:35 +0000 (18:34 +0800)
committerRobert Foss <robert.foss@linaro.org>
Mon, 14 Feb 2022 12:42:05 +0000 (13:42 +0100)
Use devm_kzalloc instead of kzalloc and drop kfree(). Let the memory
handled by driver detach.

Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Xin Ji <xji@analogixsemi.com>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220213103437.3363848-2-hsinyi@chromium.org
drivers/gpu/drm/bridge/analogix/anx7625.c

index 17b2394..b7e3373 100644 (file)
@@ -2515,7 +2515,7 @@ static int anx7625_i2c_probe(struct i2c_client *client,
                return -ENODEV;
        }
 
-       platform = kzalloc(sizeof(*platform), GFP_KERNEL);
+       platform = devm_kzalloc(dev, sizeof(*platform), GFP_KERNEL);
        if (!platform) {
                DRM_DEV_ERROR(dev, "fail to allocate driver data\n");
                return -ENOMEM;
@@ -2527,7 +2527,7 @@ static int anx7625_i2c_probe(struct i2c_client *client,
        if (ret) {
                if (ret != -EPROBE_DEFER)
                        DRM_DEV_ERROR(dev, "fail to parse DT : %d\n", ret);
-               goto free_platform;
+               return ret;
        }
 
        platform->client = client;
@@ -2552,7 +2552,7 @@ static int anx7625_i2c_probe(struct i2c_client *client,
        if (!platform->hdcp_workqueue) {
                dev_err(dev, "fail to create work queue\n");
                ret = -ENOMEM;
-               goto free_platform;
+               return ret;
        }
 
        platform->pdata.intp_irq = client->irq;
@@ -2637,9 +2637,6 @@ free_hdcp_wq:
        if (platform->hdcp_workqueue)
                destroy_workqueue(platform->hdcp_workqueue);
 
-free_platform:
-       kfree(platform);
-
        return ret;
 }
 
@@ -2666,7 +2663,6 @@ static int anx7625_i2c_remove(struct i2c_client *client)
        if (platform->pdata.audio_en)
                anx7625_unregister_audio(platform);
 
-       kfree(platform);
        return 0;
 }