drm/bridge: ti-sn65dsi86: Fix multiple instances
authorGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 10 Dec 2024 14:18:46 +0000 (15:18 +0100)
committerDouglas Anderson <dianders@chromium.org>
Tue, 7 Jan 2025 17:12:50 +0000 (09:12 -0800)
Each bridge instance creates up to four auxiliary devices with different
names.  However, their IDs are always zero, causing duplicate filename
errors when a system has multiple bridges:

    sysfs: cannot create duplicate filename '/bus/auxiliary/devices/ti_sn65dsi86.gpio.0'

Fix this by using a unique instance ID per bridge instance.  The
instance ID is derived from the I2C adapter number and the bridge's I2C
address, to support multiple instances on the same bus.

Fixes: bf73537f411b ("drm/bridge: ti-sn65dsi86: Break GPIO and MIPI-to-eDP bridge into sub-drivers")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/7a68a0e3f927e26edca6040067fb653eb06efb79.1733840089.git.geert+renesas@glider.be
drivers/gpu/drm/bridge/ti-sn65dsi86.c

index e4d9006..b3d6175 100644 (file)
@@ -480,6 +480,7 @@ static int ti_sn65dsi86_add_aux_device(struct ti_sn65dsi86 *pdata,
                                       const char *name)
 {
        struct device *dev = pdata->dev;
+       const struct i2c_client *client = to_i2c_client(dev);
        struct auxiliary_device *aux;
        int ret;
 
@@ -488,6 +489,7 @@ static int ti_sn65dsi86_add_aux_device(struct ti_sn65dsi86 *pdata,
                return -ENOMEM;
 
        aux->name = name;
+       aux->id = (client->adapter->nr << 10) | client->addr;
        aux->dev.parent = dev;
        aux->dev.release = ti_sn65dsi86_aux_device_release;
        device_set_of_node_from_dev(&aux->dev, dev);