pinctrl: bcm: nsp: implement get_direction

The get_direction api is strongly recommended to be implemented. In fact
if it is not implemented gpio-hogs will not get the correct direction.
Add an implementation of get_direction for the nsp-gpio driver.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20191104001819.2300-3-chris.packham@alliedtelesis.co.nz
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
index 45ae29b..bed0124 100644 (file)
--- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
@@ -297,6 +297,19 @@ static int nsp_gpio_direction_output(struct gpio_chip *gc, unsigned gpio,
        return 0;
 }
 
+static int nsp_gpio_get_direction(struct gpio_chip *gc, unsigned gpio)
+{
+       struct nsp_gpio *chip = gpiochip_get_data(gc);
+       unsigned long flags;
+       int val;
+
+       raw_spin_lock_irqsave(&chip->lock, flags);
+       val = nsp_get_bit(chip, REG, NSP_GPIO_OUT_EN, gpio);
+       raw_spin_unlock_irqrestore(&chip->lock, flags);
+
+       return !val;
+}
+
 static void nsp_gpio_set(struct gpio_chip *gc, unsigned gpio, int val)
 {
        struct nsp_gpio *chip = gpiochip_get_data(gc);
@@ -641,6 +654,7 @@ static int nsp_gpio_probe(struct platform_device *pdev)
        gc->free = gpiochip_generic_free;
        gc->direction_input = nsp_gpio_direction_input;
        gc->direction_output = nsp_gpio_direction_output;
+       gc->get_direction = nsp_gpio_get_direction;
        gc->set = nsp_gpio_set;
        gc->get = nsp_gpio_get;