lan743x: remove redundant statement in lan743x_ethtool_get_eee
authorHeiner Kallweit <hkallweit1@gmail.com>
Fri, 5 Jan 2024 22:19:02 +0000 (23:19 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 9 Jan 2024 03:17:44 +0000 (19:17 -0800)
eee_active is set by phy_ethtool_get_eee() already, using the same
logic plus an additional check against link speed/duplex values.
See genphy_c45_eee_is_active() for details.
So we can remove this line.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/3340ff84-8d7a-404b-8268-732c7f281164@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microchip/lan743x_ethtool.c

index 8c4a2bb..a2b3f44 100644 (file)
@@ -1077,7 +1077,6 @@ static int lan743x_ethtool_get_eee(struct net_device *netdev,
        buf = lan743x_csr_read(adapter, MAC_CR);
        if (buf & MAC_CR_EEE_EN_) {
                eee->eee_enabled = true;
-               eee->eee_active = !!(eee->advertised & eee->lp_advertised);
                eee->tx_lpi_enabled = true;
                /* EEE_TX_LPI_REQ_DLY & tx_lpi_timer are same uSec unit */
                buf = lan743x_csr_read(adapter, MAC_EEE_TX_LPI_REQ_DLY_CNT);