powerpc/xive: Drop unmask of MSIs at startup
authorCédric Le Goater <clg@kaod.org>
Thu, 1 Jul 2021 13:27:24 +0000 (15:27 +0200)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 10 Aug 2021 13:14:57 +0000 (23:14 +1000)
That was a workaround in the XIVE domain because of the lack of MSI
domain. This is now handled.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20210701132750.1475580-7-clg@kaod.org
arch/powerpc/sysdev/xive/common.c

index 823f9fe..356f584 100644 (file)
@@ -616,16 +616,6 @@ static unsigned int xive_irq_startup(struct irq_data *d)
        pr_devel("xive_irq_startup: irq %d [0x%x] data @%p\n",
                 d->irq, hw_irq, d);
 
-#ifdef CONFIG_PCI_MSI
-       /*
-        * The generic MSI code returns with the interrupt disabled on the
-        * card, using the MSI mask bits. Firmware doesn't appear to unmask
-        * at that level, so we do it here by hand.
-        */
-       if (irq_data_get_msi_desc(d))
-               pci_msi_unmask_irq(d);
-#endif
-
        /* Pick a target */
        target = xive_pick_irq_target(d, irq_data_get_affinity_mask(d));
        if (target == XIVE_INVALID_TARGET) {