sched/fair: Avoid a second scan of target in select_idle_cpu
authorMel Gorman <mgorman@techsingularity.net>
Wed, 4 Aug 2021 11:58:57 +0000 (12:58 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Wed, 4 Aug 2021 13:16:44 +0000 (15:16 +0200)
When select_idle_cpu starts scanning for an idle CPU, it starts with
a target CPU that has already been checked by select_idle_sibling.
This patch starts with the next CPU instead.

Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20210804115857.6253-3-mgorman@techsingularity.net
kernel/sched/fair.c

index 7ee394b..47a0fbf 100644 (file)
@@ -6220,7 +6220,7 @@ static int select_idle_cpu(struct task_struct *p, struct sched_domain *sd, bool
                time = cpu_clock(this);
        }
 
-       for_each_cpu_wrap(cpu, cpus, target) {
+       for_each_cpu_wrap(cpu, cpus, target + 1) {
                if (has_idle_core) {
                        i = select_idle_core(p, cpu, cpus, &idle_cpu);
                        if ((unsigned int)i < nr_cpumask_bits)