regulator: pv88060: Fix .ops for PV88060_SW
authorAxel Lin <axel.lin@ingics.com>
Fri, 15 Feb 2019 01:42:49 +0000 (09:42 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 18 Feb 2019 18:27:51 +0000 (18:27 +0000)
There is no vsel_reg/vsel_mask settings for PV88060_ID_SWx, so don't use
pv88060_ldo_ops for PV88060_SW. The PV88060_ID_SWx is fixed voltage,
set .fixed_uV instead of .min_uV then regulator core will automatically
support get_voltage and list_voltage.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/pv88060-regulator.c

index a944605..d5dab9b 100644 (file)
@@ -184,6 +184,12 @@ static const struct regulator_ops pv88060_ldo_ops = {
        .list_voltage = regulator_list_voltage_linear,
 };
 
+static const struct regulator_ops pv88060_sw_ops = {
+       .enable = regulator_enable_regmap,
+       .disable = regulator_disable_regmap,
+       .is_enabled = regulator_is_enabled_regmap,
+};
+
 #define PV88060_BUCK(chip, regl_name, min, step, max, limits_array) \
 {\
        .desc   =       {\
@@ -237,9 +243,8 @@ static const struct regulator_ops pv88060_ldo_ops = {
                .regulators_node = of_match_ptr("regulators"),\
                .type = REGULATOR_VOLTAGE,\
                .owner = THIS_MODULE,\
-               .ops = &pv88060_ldo_ops,\
-               .min_uV = max,\
-               .uV_step = 0,\
+               .ops = &pv88060_sw_ops,\
+               .fixed_uV = max,\
                .n_voltages = 1,\
                .enable_reg = PV88060_REG_##regl_name##_CONF,\
                .enable_mask = PV88060_SW_EN,\