drm/amd/pm: fix the compile warning
authorEvan Quan <evan.quan@amd.com>
Mon, 25 Apr 2022 02:16:46 +0000 (10:16 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 28 Apr 2022 21:45:49 +0000 (17:45 -0400)
Fix the compile warning below:
drivers/gpu/drm/amd/amdgpu/../pm/legacy-dpm/kv_dpm.c:1641
kv_get_acp_boot_level() warn: always true condition '(table->entries[i]->clk >= 0) => (0-u32max >= 0)'

Reported-by: kernel test robot <lkp@intel.com>
CC: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Evan Quan <evan.quan@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c

index 8b23cc9..8fd0782 100644 (file)
@@ -1623,19 +1623,7 @@ static int kv_update_samu_dpm(struct amdgpu_device *adev, bool gate)
 
 static u8 kv_get_acp_boot_level(struct amdgpu_device *adev)
 {
-       u8 i;
-       struct amdgpu_clock_voltage_dependency_table *table =
-               &adev->pm.dpm.dyn_state.acp_clock_voltage_dependency_table;
-
-       for (i = 0; i < table->count; i++) {
-               if (table->entries[i].clk >= 0) /* XXX */
-                       break;
-       }
-
-       if (i >= table->count)
-               i = table->count - 1;
-
-       return i;
+       return 0;
 }
 
 static void kv_update_acp_boot_level(struct amdgpu_device *adev)