drm/amdgpu: error out on entity with no run queue
authorNirmoy Das <nirmoy.das@amd.com>
Thu, 9 Jan 2020 11:07:22 +0000 (12:07 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 16 Jan 2020 18:35:03 +0000 (13:35 -0500)
Disabled HW IP's entity initialized with NULL rq. We should not
process any submit request from userspace for a disabled HW IP.

Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

index 5b330f6..7a8772b 100644 (file)
@@ -909,6 +909,11 @@ static int amdgpu_cs_ib_fill(struct amdgpu_device *adev,
                if (parser->entity && parser->entity != entity)
                        return -EINVAL;
 
+               /* Return if there is no run queue associated with this entity.
+                * Possibly because of disabled HW IP*/
+               if (entity->rq == NULL)
+                       return -EINVAL;
+
                parser->entity = entity;
 
                ring = to_amdgpu_ring(entity->rq->sched);