hwmon: (nzxt-smart2) Use devm_mutex_init()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 7 Sep 2025 10:20:20 +0000 (12:20 +0200)
committerGuenter Roeck <linux@roeck-us.net>
Sun, 7 Sep 2025 23:35:18 +0000 (16:35 -0700)
Use devm_mutex_init() instead of hand-writing it.

This saves some LoC, improves readability and saves some space in the
generated .o file.

Before:
======
   text    data     bss     dec     hex filename
  25878   11329     128   37335    91d7 drivers/hwmon/nzxt-smart2.o

After:
=====
   text    data     bss     dec     hex filename
  25551   11257     128   36936    9048 drivers/hwmon/nzxt-smart2.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/f51fac0871ec7dbe4e28447ee4f774d028a53426.1757240403.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/nzxt-smart2.c

index c2d1173..58ef9fa 100644 (file)
@@ -721,11 +721,6 @@ static int __maybe_unused nzxt_smart2_hid_reset_resume(struct hid_device *hdev)
        return init_device(drvdata, drvdata->update_interval);
 }
 
-static void mutex_fini(void *lock)
-{
-       mutex_destroy(lock);
-}
-
 static int nzxt_smart2_hid_probe(struct hid_device *hdev,
                                 const struct hid_device_id *id)
 {
@@ -741,8 +736,7 @@ static int nzxt_smart2_hid_probe(struct hid_device *hdev,
 
        init_waitqueue_head(&drvdata->wq);
 
-       mutex_init(&drvdata->mutex);
-       ret = devm_add_action_or_reset(&hdev->dev, mutex_fini, &drvdata->mutex);
+       ret = devm_mutex_init(&hdev->dev, &drvdata->mutex);
        if (ret)
                return ret;